Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7692

"Fix: This is a fix for Clicking anywhere generates JS warnings in Firefox if a dropdown menu is present Issue #7318

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shishirmk/master into master Apr 25, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: shishirmk

When jQuery receives an empty id selector like this $("#") , it throws an error in firefox. This error is visible only in the web console provided by firefox. I was not able to see it in firebug console. I have just added a if statement as a workaround for it.

Here is the diff

--- a/js/bootstrap-dropdown.js
+++ b/js/bootstrap-dropdown.js
@@ -118,7 +118,11 @@
       selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //st
     }

-    $parent = selector && $(selector)
+    if (selector === "#"){
+      $parent = $("")
+    } else {
+      $parent = selector && $(selector)
+    }

 if (!$parent || !$parent.length) $parent = $this.parent()

This is my first pull request hope I have done it right

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shishirmk/master