Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7857

affix positioning and this.unpin update

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/buberdds/3.0.0-wip-affix-fix into 3.0.0-wip May 12, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: buberdds

Fix for "affix bottom" and "affix key up,down,pageup, pagedown" issues.

How to reproduce a problem on the twitter site:

  • navigate to http://twitter.github.io/bootstrap/javascript.html
  • left menu must be higher then visible part of the container (so u can't see all links of the "nav nav-list bs-docs-sidenav" element)
  • it's visible on lower resolutions or when you reduce height of a viewport/browser window
  • you can even open the dev tools and dock it horizontally
  • press a key: end or pgdn a few times and the sidebar should float over the footer

in chrome/ff u should see the problem while pressing the pgdn key, in IE while pressing home etc

There is an another problem with affix position. When you scrolldown to the bottom of the page and refresh a page(F5), sidebar will float over footer.

If you can reproduce the problem with the above description you can verify commit in the chrome dev tools: ctrl+shift+f type in affix and click on bootstrap-affix.js content. Ctrl+a and delete the content. Then paste in https://raw.github.com/buberdds/bootstrap/3.0.0-wip-affix-fix/js/bootstrap-affix.js and hit ctrl+s.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/buberdds/3.0.0-wip-affix-fix