Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !8158

Docs "Customize and Download" button didn't send the correct parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/baer/download-button-fix-proper into 3.0.0-wip Jun 12, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: baer

The "Download and Customize" button was not working as expected the following problems were fixed:

  • The click handler wasn't preventing default which caused the page to jump to the top
  • The ajax post was ALWAYS go to the heroku app because the check for dev/prod was incorrect
  • The post send empty arrays as parameters because it was not selecting the correct divs to gather the input values.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/baer/download-button-fix-proper