Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !8358

Fix responsive utilities for table elements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/juthilo/3.0.0-responsive-tables into 3.0.0-wip Jul 01, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: juthilo

This change prevents situations where specificity causes some rules to be overridden by the ones intended for mobile.

  • Added mixin responsive-invisibility()
  • Swapped out display: none !important; for new mixin in responsive-utilities.less

What does this fix? Scenario

Viewport matches desktop media query. The tag in question is a td.visible-sm.

  1. .visible-sm { display: block !important; } Table cell would be visible on mobile
  2. .visible-sm { display: none !important; } Media query kicks in, table cell would be hidden on desktop
  3. td.visible-sm { display: table-cell !important; } Other rules overridden due to specificity in rules for phone. Table cell unintentionally visible on desktop
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/juthilo/3.0.0-responsive-tables