Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !8474

Improve carousel example

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ssorallen/3.0.0-wip into 3.0.0-wip Jul 13, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ssorallen

I tried using the carousel example's CSS from the 2.3.x branch for a project and noticed that it didn't work well on pages without a carousel. This keeps the carousel example working the same and lets the floating navbar be used on pages without carousels.

Specificity change:

The specificity change was specific to the 3.x branch. Slides were not the height of the container: screen shot 2013-07-13 at 12 45 49 pm

Matching specificity fixed it: screen shot 2013-07-13 at 12 45 13 pm

Navbar change:

Hiding the carousel shows these styles don't work well without a carousel: screen shot 2013-07-13 at 12 48 51 pm

Letting the navbar flow and moving the negative margin means the carousel still works, and the styles can be used on carousel-free pages: screen shot 2013-07-13 at 12 47 04 pm

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ssorallen/3.0.0-wip