Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !8622

use .form-group in .form-horizontal for application of consistent vertical form spacing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jholl/patch-3 into 3.0.0-wip Jul 26, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: jholl

Not totally sold myself on this but with .form-group having margin bottom, might be more consistent to use this in .form-horizontal instead of using .form-horizontal .row + .row. - here's jsfiddle but pretty clear http://jsfiddle.net/jholl/Qfv36/

Things I don't like:

  • adds extra mark-up
  • forces use of a margin at bottom of form or awkwardly drop class .form-group on final div...

Things I do like:

  • all form vertical spacing can be controlled with .form-group
  • feels more consistent application of .form-group for new users

@mdo, you decide.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jholl/patch-3