Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !9403

BS3: Navbar overhaul

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge bs3_navbar_overhaul into 3.0.0-wip Aug 13, 2013
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 9

screen shot 2013-08-12 at 9 39 27 pm

This overhauls our navbars to address a few items:

  • Navbars are now responsive by default (fits better with mobile first approach)
  • Navbars now require .nav-header to group .navbar-brand and .navbar-toggle for proper mobile display in conjunction with the collapsed content.
  • Renamed .nav-collapse to .navbar-collapse for a more consistent naming convention.
  • Refactored dropdown menus to use the old 2.x approach (no longer absolutely positioned, but rather as navbar nav links). Fixes #8792 (closed).
  • Simplified examples in docs to only highlight content not displayed in the first navbar example.

It can add some heft to an otherwise lightweight navbar, but I think all these improvements help the component and make it more durable in the long run. Still needs some finessing, but it's close I think.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bs3_navbar_overhaul