Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !9970

honor @grid-columns by un-hardcoding grid classes; fixes #9436

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge parameterize-num-grid-cols into master Aug 21, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: cvrebert

Fixes #9436 (closed). Tested on 12 and 13 columns, and it seems to do the right thing. Could probably use some more vetting. /to @mdo

The generated CSS has 2 differences:

  1. The list of classes in the common grid column styling declaration is changed because I don't know of (or it's impossible without a horrible kludge?) a way to loop over a list of strings in LESS, which would be necessary to replicate the original ordering.
  2. Adds .col-sm-push-0, .col-sm-pull-0, and .col-sm-offset-0, since there's no special-casing of sm. AFAIK, they have no real effect, so there's no point in using them in handwritten code, but it's slightly nice to have them for uniformity's sake.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: parameterize-num-grid-cols