Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • J js-stack-from-scratch
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Verekia
  • js-stack-from-scratch
  • Merge requests
  • !79

Change gitignore files to relative paths and fix READMEs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/senk/fix-gitignore into master 8 years ago
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 12

Created by: senk

  • Fix READMEs introducing wrong gitignore entries
  • Change .gitignore files to include correct relative paths
Approval is optional

Closed by (Jul 28, 2025 8:20am UTC)

Merge details

  • The changes were not merged into master.

Activity


  • Verekia
    Verekia @verekia · 8 years ago
    Owner

    Using absolute paths for these was not a mistake. In big projects, it could happen for some third party lib folder to be used deeper than the root level. Using relative paths would break this by ignoring every lib folder, which is not what we want (unlike node_modules, which we always want to ignore).

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: senk

    You're absolutely right. Thanks for pointing that out :)

  • Administrator closed 8 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Verekia
Administrator
Reference: verekia/js-stack-from-scratch!79
Source branch: github/fork/senk/fix-gitignore

Menu

Explore Projects Groups Snippets