Skip to content
GitLab

Use flock instead of temporary files to avoid races/purge on ENOSPC/fsync time

Closed Administrator requested to merge github/fork/azat-archive/flock-v2 into master

Created by: azat

  • races: two parallel autojump --add can lead to database purging (overwriting by one of tmp files)
  • ENOSPC: will leave autojump.txt empty, because no free space available
  • fsync: can take a while

All of this can be fixed with fsync(2).

P.S. maybe there are some issues on win32, and/or not all places didn't guard by flock.