Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A autojump
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 158
    • Issues 158
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • William Ting
  • autojump
  • Merge requests
  • !561

Fix improper backslash handeling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Chris requested to merge github/fork/MrKriss/master into master Mar 04, 2019
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 3

Fixes #436 #522 (closed) and #543

Root cause was the improper backslash handeling. I have implimented the fix suggested in #436 and ammended the reference data in the tests so they now pass on Windows. I also created an is_windows variable bassed on detecting the platform, and skipped tests that were failing due to differences in the path sep and drive character.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MrKriss/master