Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P pyod
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 144
    • Issues 144
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Yue Zhao
  • pyod
  • Issues
  • #409
Closed
Open
Issue created Jun 03, 2022 by Administrator@rootContributor

generate_data from data.py causes warning with default flags because of parameter deprecation that never happened

Created by: rkost

I am new to this project but haven't found a related issue.

data.py provides the function generate_data:

https://github.com/yzhao062/pyod/blob/bb3a14ea4df149e3773fa34116dfc62e1c8d5c89/pyod/utils/data.py#L112-L114

The parameter behavior is set to old by default which causes a warning to be displayed, notifying about this behavior getting deprecated in version 0.9.0.

The 'fix' would be to call the function with behavior='new' as it would not warn you about anything, however the documentation states, that the parameter will be removed altogether in 0.9.0. I guess that never happened since we are now on 1.0.1?

https://github.com/yzhao062/pyod/blob/bb3a14ea4df149e3773fa34116dfc62e1c8d5c89/pyod/utils/data.py#L142-L155

Can we just move on and either remove that parameter now or un-deprecate it, if it is that important? We would need to go through all examples and tests and change the order of the expected return values, right? I would happily do that so that I can rely on this python package.

I also wondered why the tests would not fail when there are warnings?

Assignee
Assign to
Time tracking